Supporting decoupled tracks from main BGM bank #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional parameter to choose if samples must be included in the individual tracks SWD or to the main bank
The sound engine actually supports using a pre-defined pcmd chunk inside of the individual tracks to store track samples instead of creating one in memory using bits of the main bank
Main advantage of decoupled tracks
Portability: allows individual generated SMD/SWD tracks not to be linked to any external SWD bank, which means they can be copied to any ROM without needing to change the main bank (this could also work with other games using the same engine that do not have a main BGM bank, but not verified)
Main drawback of decoupled tracks
Memory usage: takes a bit more space than storing to the main bank, as samples reused between several tracks are not shared
Note: this only affect ROM memory usage, in game RAM memory usage is equivalent no matter what method is preferred