Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion failed #2

Closed
End45 opened this issue Sep 21, 2023 · 1 comment
Closed

Assertion failed #2

End45 opened this issue Sep 21, 2023 · 1 comment

Comments

@End45
Copy link

End45 commented Sep 21, 2023

Description of the bug
I tried to import a midi + sf2 song that I ripped from another game using VgmTrans v1.1 and got an assertion error.

Recordings
The midi and sf2 files are attached, as well as the config file used.
test.zip

Desktop

  • OS: Windows
  • Version: The program doesn't specify this anywhere, but it should be 0.1.0.
@adakite1
Copy link
Owner

adakite1 commented Sep 21, 2023

This assertion is for detecting when duplicate presets exist in the soundfont with the same shared bank/preset ids, which should never happen, but weirdly in this case while no duplicate presets can be seen from Polyphone, the library that I am using to parse the soundfont returns the following:
image
A second preset after all the normal ones with a bank/preset id of 000:000, and with no sample mappings inside, an empty preset. I'm not sure if this is due to a rule in the specs to ignore empty presets, but this seems like the most likely explanation. An interesting observation was that Polyphone opens the file correctly, and it also works in ssb after being re-exported from Polyphone.
Since the preset causing problems is empty, a filter stripping away any empty presets solves this problem, and future soundfonts containing empty preset should also be readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants