refactor!: require vscode 1.71+, jest 29+

also: - reworks e2e tests to reliably pass - switched node-ipc out for @achrinza/node-ipc due to security concerns
adalinesimonian · Oct 5, 2022 · f779c3a · f779c3a
1 parent e4d82c5
commit f779c3a
Show file tree

Hide file tree

Showing 59 changed files with 19,150 additions and 2,127 deletions.
diff --git a/.gitignore b/.gitignore
@@ -10,11 +10,4 @@ node_modules
 # build artifacts
 /dist
 tsconfig.tsbuildinfo
-e2e/**/jest-output.json
-e2e/**/yarn.lock
-e2e/**/.pnp.*
-e2e/**/.vscode-test
 package.tgz
-
-# vscode binaries
-.vscode-test
diff --git a/.vscode-test/.gitignore b/.vscode-test/.gitignore
@@ -0,0 +1 @@
+*/
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -1,31 +1,14 @@
 {
-  "editor.rulers": [
-    80,
-    120
-  ],
+  "editor.rulers": [80, 120],
   "search.exclude": {
     ".yarn": true,
     "dist": true,
     "**/.yarn": true,
     "**/.pnp.*": true
   },
-  "[javascript]": {
-    "editor.defaultFormatter": "esbenp.prettier-vscode"
-  },
-  "[typescript]": {
-    "editor.defaultFormatter": "esbenp.prettier-vscode"
-  },
-  "[json]": {
-    "editor.defaultFormatter": "esbenp.prettier-vscode"
-  },
-  "[jsonc]": {
-    "editor.defaultFormatter": "esbenp.prettier-vscode"
-  },
-  "[markdown]": {
-    "editor.defaultFormatter": "esbenp.prettier-vscode"
-  },
-  "[yaml]": {
-    "editor.defaultFormatter": "esbenp.prettier-vscode"
+  "[javascript][typescript][json][jsonc][markdown][yaml]": {
+    "editor.defaultFormatter": "esbenp.prettier-vscode",
+    "editor.formatOnSave": true
   },
   "typescript.tsdk": ".yarn/sdks/typescript/lib",
   "eslint.nodePath": ".yarn/sdks",

diff --git a/.yarn/releases/yarn-3.2.3.cjs b/.yarn/releases/yarn-3.2.3.cjs
diff --git a/.yarn/sdks/eslint/bin/eslint.js b/.yarn/sdks/eslint/bin/eslint.js
diff --git a/.yarn/sdks/prettier/index.js b/.yarn/sdks/prettier/index.js
diff --git a/.yarn/sdks/typescript/bin/tsc b/.yarn/sdks/typescript/bin/tsc
diff --git a/.yarn/sdks/typescript/bin/tsserver b/.yarn/sdks/typescript/bin/tsserver
diff --git a/e2e/.gitignore b/e2e/.gitignore
@@ -0,0 +1,5 @@
+*/.yarn/*
+!*/.yarn/releases
+**/jest-output.json
+**/.pnp.*
+/.yarn/cache/*
diff --git a/e2e/.yarnrc.base.yml b/e2e/.yarnrc.base.yml
@@ -0,0 +1 @@
+cacheFolder: ../.yarn/cache
diff --git a/e2e/__tests__/__snapshots__/failing-tests.ts.snap b/e2e/__tests__/__snapshots__/failing-tests.ts.snap
@@ -1,7 +1,7 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`Failing tests should fail tests 1`] = `
-Object {
+{
   "numFailedTestSuites": 2,
   "numFailedTests": 2,
   "numPassedTestSuites": 0,
@@ -12,45 +12,47 @@ Object {
   "numTodoTests": 0,
   "numTotalTestSuites": 2,
   "numTotalTests": 2,
-  "openHandles": Array [],
-  "snapshot": Object {
+  "openHandles": [],
+  "snapshot": {
     "added": 0,
     "didUpdate": false,
     "failure": false,
     "filesAdded": 0,
     "filesRemoved": 0,
-    "filesRemovedList": Array [],
+    "filesRemovedList": [],
     "filesUnmatched": 0,
     "filesUpdated": 0,
     "matched": 0,
     "total": 0,
     "unchecked": 0,
-    "uncheckedKeysByFile": Array [],
+    "uncheckedKeysByFile": [],
     "unmatched": 0,
     "updated": 0,
   },
   "startTime": undefined,
   "success": false,
-  "testResults": Array [
-    Object {
-      "assertionResults": Array [
-        Object {
-          "ancestorTitles": Array [
+  "testResults": [
+    {
+      "assertionResults": [
+        {
+          "ancestorTitles": [
             "Describe",
           ],
-          "failureMessages": Array [
+          "duration": undefined,
+          "failureMessages": [
             "",
           ],
           "fullName": "Describe should test",
           "location": null,
           "status": "failed",
           "title": "should test",
         },
-        Object {
-          "ancestorTitles": Array [
+        {
+          "ancestorTitles": [
             "Describe",
           ],
-          "failureMessages": Array [
+          "duration": undefined,
+          "failureMessages": [
             "",
           ],
           "fullName": "Describe should test async",
@@ -67,9 +69,9 @@ Object {
       "status": "failed",
       "summary": "",
     },
-    Object {
-      "assertionResults": Array [],
-      "coverage": Object {},
+    {
+      "assertionResults": [],
+      "coverage": {},
       "endTime": undefined,
       "failureMessage": "",
       "message": "",

diff --git a/e2e/__tests__/__snapshots__/passing-tests.ts.snap b/e2e/__tests__/__snapshots__/passing-tests.ts.snap
@@ -1,7 +1,7 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`Passing tests should pass tests 1`] = `
-Object {
+{
   "numFailedTestSuites": 0,
   "numFailedTests": 0,
   "numPassedTestSuites": 2,
@@ -12,31 +12,32 @@ Object {
   "numTodoTests": 0,
   "numTotalTestSuites": 2,
   "numTotalTests": 4,
-  "openHandles": Array [],
-  "snapshot": Object {
+  "openHandles": [],
+  "snapshot": {
     "added": 0,
     "didUpdate": false,
     "failure": false,
     "filesAdded": 0,
     "filesRemoved": 0,
-    "filesRemovedList": Array [],
+    "filesRemovedList": [],
     "filesUnmatched": 0,
     "filesUpdated": 0,
     "matched": 0,
     "total": 0,
     "unchecked": 0,
-    "uncheckedKeysByFile": Array [],
+    "uncheckedKeysByFile": [],
     "unmatched": 0,
     "updated": 0,
   },
   "startTime": undefined,
   "success": true,
-  "testResults": Array [
-    Object {
-      "assertionResults": Array [
-        Object {
-          "ancestorTitles": Array [],
-          "failureMessages": Array [],
+  "testResults": [
+    {
+      "assertionResults": [
+        {
+          "ancestorTitles": [],
+          "duration": undefined,
+          "failureMessages": [],
           "fullName": "should pass a test in a subdirectory",
           "location": null,
           "status": "passed",
@@ -51,33 +52,36 @@ Object {
       "status": "passed",
       "summary": "",
     },
-    Object {
-      "assertionResults": Array [
-        Object {
-          "ancestorTitles": Array [
+    {
+      "assertionResults": [
+        {
+          "ancestorTitles": [
             "Describe",
           ],
-          "failureMessages": Array [],
+          "duration": undefined,
+          "failureMessages": [],
           "fullName": "Describe should test",
           "location": null,
           "status": "passed",
           "title": "should test",
         },
-        Object {
-          "ancestorTitles": Array [
+        {
+          "ancestorTitles": [
             "Describe",
           ],
-          "failureMessages": Array [],
+          "duration": undefined,
+          "failureMessages": [],
           "fullName": "Describe should test async",
           "location": null,
           "status": "passed",
           "title": "should test async",
         },
-        Object {
-          "ancestorTitles": Array [
+        {
+          "ancestorTitles": [
             "Describe",
           ],
-          "failureMessages": Array [],
+          "duration": undefined,
+          "failureMessages": [],
           "fullName": "Describe should test with logs",
           "location": null,
           "status": "passed",

diff --git a/e2e/__tests__/__snapshots__/snapshots.ts.snap b/e2e/__tests__/__snapshots__/snapshots.ts.snap
@@ -1,7 +1,7 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`Snapshot tests should pass tests 1`] = `
-Object {
+{
   "numFailedTestSuites": 0,
   "numFailedTests": 0,
   "numPassedTestSuites": 1,
@@ -12,43 +12,45 @@ Object {
   "numTodoTests": 0,
   "numTotalTestSuites": 1,
   "numTotalTests": 2,
-  "openHandles": Array [],
-  "snapshot": Object {
+  "openHandles": [],
+  "snapshot": {
     "added": 0,
     "didUpdate": false,
     "failure": false,
     "filesAdded": 0,
     "filesRemoved": 0,
-    "filesRemovedList": Array [],
+    "filesRemovedList": [],
     "filesUnmatched": 0,
     "filesUpdated": 0,
     "matched": 2,
     "total": 2,
     "unchecked": 0,
-    "uncheckedKeysByFile": Array [],
+    "uncheckedKeysByFile": [],
     "unmatched": 0,
     "updated": 0,
   },
   "startTime": undefined,
   "success": true,
-  "testResults": Array [
-    Object {
-      "assertionResults": Array [
-        Object {
-          "ancestorTitles": Array [
+  "testResults": [
+    {
+      "assertionResults": [
+        {
+          "ancestorTitles": [
             "Describe",
           ],
-          "failureMessages": Array [],
+          "duration": undefined,
+          "failureMessages": [],
           "fullName": "Describe should test",
           "location": null,
           "status": "passed",
           "title": "should test",
         },
-        Object {
-          "ancestorTitles": Array [
+        {
+          "ancestorTitles": [
             "Describe",
           ],
-          "failureMessages": Array [],
+          "duration": undefined,
+          "failureMessages": [],
           "fullName": "Describe should test async",
           "location": null,
           "status": "passed",

diff --git a/e2e/__tests__/__snapshots__/ts-passing-tests.ts.snap b/e2e/__tests__/__snapshots__/ts-passing-tests.ts.snap
@@ -1,7 +1,7 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`Passing tests (ts-jest) should pass tests 1`] = `
-Object {
+{
   "numFailedTestSuites": 0,
   "numFailedTests": 0,
   "numPassedTestSuites": 1,
@@ -12,43 +12,45 @@ Object {
   "numTodoTests": 0,
   "numTotalTestSuites": 1,
   "numTotalTests": 2,
-  "openHandles": Array [],
-  "snapshot": Object {
+  "openHandles": [],
+  "snapshot": {
     "added": 0,
     "didUpdate": false,
     "failure": false,
     "filesAdded": 0,
     "filesRemoved": 0,
-    "filesRemovedList": Array [],
+    "filesRemovedList": [],
     "filesUnmatched": 0,
     "filesUpdated": 0,
     "matched": 0,
     "total": 0,
     "unchecked": 0,
-    "uncheckedKeysByFile": Array [],
+    "uncheckedKeysByFile": [],
     "unmatched": 0,
     "updated": 0,
   },
   "startTime": undefined,
   "success": true,
-  "testResults": Array [
-    Object {
-      "assertionResults": Array [
-        Object {
-          "ancestorTitles": Array [
+  "testResults": [
+    {
+      "assertionResults": [
+        {
+          "ancestorTitles": [
             "Describe",
           ],
-          "failureMessages": Array [],
+          "duration": undefined,
+          "failureMessages": [],
           "fullName": "Describe should test",
           "location": null,
           "status": "passed",
           "title": "should test",
         },
-        Object {
-          "ancestorTitles": Array [
+        {
+          "ancestorTitles": [
             "Describe",
           ],
-          "failureMessages": Array [],
+          "duration": undefined,
+          "failureMessages": [],
           "fullName": "Describe should test async",
           "location": null,
           "status": "passed",