Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csv-parse minor version upgrade #255

Open
paton opened this issue Oct 6, 2019 · 3 comments
Open

csv-parse minor version upgrade #255

paton opened this issue Oct 6, 2019 · 3 comments

Comments

@paton
Copy link

paton commented Oct 6, 2019

We noticed that with "csv": "5.1.3", in package.json, the csv module upgrades csv-parse dependency from 4.4.7 to 4.6.3 without a version change of the parent csv module.

(csv-parse 4.6.x has a breaking change and caused our tests to break)

Is this by design?

I'm guessing the solution is for us to switch to requiring the individual modules directly instead of the parent module so we can target specific versions, but just posting this as quick feedback (convenience of the wrapper package is nice, except when there are breaking in the dependencies that autoupgrade without a version change)

@wdavidw
Copy link
Member

wdavidw commented Oct 6, 2019

Which breaking change are you referring to because 4.6 introduces enriched errors and shouldn't come with any breaking change unless you rely on error message which I wouldn't personally consider a breaking change (even so, the majority of error messages didn't changed at all).

@paton
Copy link
Author

paton commented Oct 7, 2019

@wdavidw

An error message changed from

Error: Invalid opening quote at line 4

to

Invalid Opening Quote: a quote is found inside a field at line 4

which tripped up our test suite.

It's a very minor change in the public API, so I agree it probably shouldn't be called a breaking change.

We'll switch to requiring the dependencies directly in the future 👍

@wdavidw
Copy link
Member

wdavidw commented Oct 7, 2019

The irony is that the commit attempt to fix this issue by introducing an error code and additional properties to the error object which will be taken into account in the versioning to not have to rely on the error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants