You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We noticed that with "csv": "5.1.3", in package.json, the csv module upgrades csv-parse dependency from 4.4.7 to 4.6.3 without a version change of the parent csv module.
(csv-parse 4.6.x has a breaking change and caused our tests to break)
Is this by design?
I'm guessing the solution is for us to switch to requiring the individual modules directly instead of the parent module so we can target specific versions, but just posting this as quick feedback (convenience of the wrapper package is nice, except when there are breaking in the dependencies that autoupgrade without a version change)
The text was updated successfully, but these errors were encountered:
Which breaking change are you referring to because 4.6 introduces enriched errors and shouldn't come with any breaking change unless you rely on error message which I wouldn't personally consider a breaking change (even so, the majority of error messages didn't changed at all).
The irony is that the commit attempt to fix this issue by introducing an error code and additional properties to the error object which will be taken into account in the versioning to not have to rely on the error message.
We noticed that with
"csv": "5.1.3",
in package.json, the csv module upgradescsv-parse
dependency from 4.4.7 to 4.6.3 without a version change of the parentcsv
module.(csv-parse 4.6.x has a breaking change and caused our tests to break)
Is this by design?
I'm guessing the solution is for us to switch to requiring the individual modules directly instead of the parent module so we can target specific versions, but just posting this as quick feedback (convenience of the wrapper package is nice, except when there are breaking in the dependencies that autoupgrade without a version change)
The text was updated successfully, but these errors were encountered: