fix(code): hoistOnInit

Return an unsubscribe function to prevent leaks
adam-26 · Mar 1, 2018 · c5b6c28 · c5b6c28
1 parent fd26dd4
commit c5b6c28
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/index.js b/src/index.js
@@ -218,15 +218,23 @@ function createChunkComponent(loadFn, options) {
 
         if (!opts.hoistStatics) {
           // nothing to hoist
-          return;
+          return noop;
         }
 
         if (res && res.loaded) {
           hoistNonActionStatics(getTargetComponent(), opts.resolveDefaultImport(res.loaded));
-          return;
+          return noop;
         }
 
         dynamicHoistComponentGetters.push(getTargetComponent);
+
+        // Return an unsubscribe function
+        return () => {
+          const idx = dynamicHoistComponentGetters.indexOf(getTargetComponent);
+          if (idx !== -1) {
+            dynamicHoistComponentGetters.splice(idx, 1);
+          }
+        };
       }
 
       _loadChunks() {