Merge API Changes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of only passing `loaded` to custom `render()`, pass _state_ to give full control when rendering the dynamically loaded component(s).
This allows easily implementing behaviors such as transitions, and blocking of nested route rendering until all modules are loaded.
This is _almost_ entirely backwards compatible. The **only** change required by users of previous versions is to use `object destructuring` syntax for the “loaded” argument.
Example: `render(loaded, props)` must change to `render({ loaded }, props)`
This can be done with a simple find & replace.
Allows developers to manually preload webpack modules. **example use-case**: _preloading all modules required by a deeply nested route_ When dynamically loading a deeply nested route (many levels deep), you can provide a better user experience when all required modules are loaded before rendering the route for the user. * This prevents a waterfall rendering of nested components. * Allows developers to handle errors and display an error page if the route fails to load, rather than having to display error messages for each component/module that failed to load
Reduces file size, and makes debugging easier.
Modified PR to make it fully backward compatible. If a `Loadable` defines a `loading` prop, the component will behave exactly as it has previously. When no `loading` prop is defined, the first argument the render method receives is `state` instead of `loaded`. Added support for rendering using react elements.
Allow the webpack plugin to ignore specific chunk names when writing the manifest file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for forked release