Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 [Bug] : Error in creating new tab in editor with prefilled Microsoft 365 CLI Script #67

Closed
Saurabh7019 opened this issue Jun 11, 2023 · 5 comments · Fixed by #68
Closed
Assignees
Labels
🪲bug Something isn't working

Comments

@Saurabh7019
Copy link

📝 Describe the bug

Error occurs when selecting a script in CLI for Microsoft 365 VS Code Extension samples: 'Error while creating script file based on sample.

👣 Steps To Reproduce

Steps to reproduce the behavior:

  1. Open the CLI for Microsoft 365 extension in Visual Studio Code.
  2. Select the "CLI for Microsoft 365 Samples" option.
  3. Click on the "Script" button on a sample tile.

📜 Expected behavior

A new tab should open in Visual Studio Code, and the corresponding script should load within that tab.

📷 Screenshots

image

💻 Desktop (please complete the following information):

  • OS: Windows 11 Enterprise
@Saurabh7019 Saurabh7019 added the 🪲bug Something isn't working label Jun 11, 2023
@Adam-it
Copy link
Owner

Adam-it commented Jun 11, 2023

@Saurabh7019 thanks for the feedback. I already know what is the issue, since in CLI for M365 we migrated docs from mkdocs do docusource and there is a slightly different format in the way we now store samples.
As the extensions just 'cuts out' the script from sample file from the repo probably the way I split the sample is currently not valid anymore.

So additional info is that this bug will only happen for script samples coming from CLI repo bit from PnP script samples repo (that's why probably I did not notice it during testing 🤦‍♂️)

I planned to spend some time today on this extensions so I will look into this bug ASAP. 👍

@Adam-it Adam-it self-assigned this Jun 11, 2023
@Saurabh7019
Copy link
Author

No rush! I just wanted to bring it to your attention.

@Adam-it
Copy link
Owner

Adam-it commented Jun 11, 2023

@Saurabh7019 BTW, I know it's not part of this issue so if you want we could move this to some different chat or any other place, but from the screen shoot I noticed you also have the Viva Connections Toolkit 👀. TBH I am looking for some feedback on this extension and I was wondering if you would be so kind and maybe you could share some comments or observations about this extension? Do you see something lacking or not useful? Any kind of feedback will be helpful ♥️

@Saurabh7019
Copy link
Author

Absolutely! I would be happy to thoroughly explore the extension and provide you with my observations and any suggestions for improvement.

@Adam-it
Copy link
Owner

Adam-it commented Jun 11, 2023

Absolutely! I would be happy to thoroughly explore the extension and provide you with my observations and any suggestions for improvement.

Thanks, you rock 🤩. Reach me out or open an issue on the Viva vs code extension 👍. I will keep an eye out for your feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants