Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sed on Makefile looks wrong #1

Closed
hatoo opened this issue Apr 25, 2024 · 1 comment
Closed

sed on Makefile looks wrong #1

hatoo opened this issue Apr 25, 2024 · 1 comment

Comments

@hatoo
Copy link

hatoo commented Apr 25, 2024

Hi, thanks for publishing this repository!
During testing on my side, it seems that the Makefile is wrong.

I'm not very familiar with sed, but I think

sed -i '' '1s/^/`timescale 1ns\/1ns\n/' build/gpu.v

should be

sed -i '1s/^/`timescale 1ns\/1ns\n/' build/gpu.v

and I've also noticed that running a simulation requires compiling https://github.com/zachjs/sv2v from the source
because it seems using https://github.com/zachjs/sv2v/blob/261beffd0f4dd26bd1a19d574bbcc2caabba2eaa/CHANGELOG.md?plain=1#L42 which is not released yet. I think this information is good to add somewhere in README.

@xianbaoqian
Copy link
Contributor

I managed to run this on my macbook. Created a PR with some instructions: #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants