Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative numbers are interpreted as options #49

Closed
adambajguz opened this issue Oct 10, 2020 · 0 comments · Fixed by #54
Closed

Negative numbers are interpreted as options #49

adambajguz opened this issue Oct 10, 2020 · 0 comments · Fixed by #54
Assignees
@adambajguz
Labels
bug Something isn't working Typin Typin library related issues
Projects
Typin upgrades
Milestone
v2.1

Comments

@adambajguz
Copy link
Owner

adambajguz commented Oct 10, 2020 •
edited

[preview] column change-range iris$pw --min -20 --max 20 => column change-range <iris$pw> [--min] [-2] [-0] [--max "20"]

Solution: options should newer start with a digit + implement escaping (check how cmd handles " - so maybe ' escaping?). Then, -2, -2d, and "--opt" are always treated as argument values (related #45).
@adambajguz adambajguz added the bug Something isn't working label Oct 10, 2020
@adambajguz adambajguz self-assigned this Oct 10, 2020
@adambajguz adambajguz added this to To do in Maintenance via automation Oct 10, 2020
@adambajguz adambajguz moved this from To do to To fix in Maintenance Oct 13, 2020
@adambajguz adambajguz moved this from To fix to In progress in Maintenance Oct 17, 2020
@adambajguz adambajguz added this to the v2.2 milestone Oct 17, 2020
@adambajguz adambajguz removed this from In progress in Maintenance Oct 17, 2020
@adambajguz adambajguz added this to In progress in Typin upgrades Oct 17, 2020
@adambajguz adambajguz modified the milestones: v2.2, v2.1 Oct 17, 2020
@adambajguz adambajguz mentioned this issue Oct 17, 2020
Merged
@adambajguz adambajguz linked a pull request Oct 17, 2020 that will close this issue
Feature/issue 49 negative numbers #54
Merged
@adambajguz adambajguz moved this from In progress to Done in Typin upgrades Oct 17, 2020
@adambajguz adambajguz added the Typin Typin library related issues label Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adambajguz adambajguz

Labels
bug Something isn't working Typin Typin library related issues
Projects
Typin upgrades
  
Done
Milestone
v2.1
Development

Successfully merging a pull request may close this issue.

Feature/issue 49 negative numbers adambajguz/Typin
1 participant
@adambajguz