Make virtualfish work without installation #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daisylb
requested changes
Nov 27, 2017
virtualfish/__main__.py
Outdated
| version = pkg_resources.get_distribution('virtualfish').version | ||
| try: | ||
| version = pkg_resources.get_distribution('virtualfish').version | ||
| except: |
There was a problem hiding this comment.
I'd prefer it if you caught a specific exception here instead of using a bare except block.
amezin
force-pushed
the
master
branch
2 times, most recently
from
fa2bc0a
to
029b9d2
Compare
|
Fixed. |
|
@adambrenecki ping |
daisylb
approved these changes
Jan 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to keep my shell configuration in a git repository, and avoid manual installation steps as much as possible.
I store 'virtualenv' and 'virtualfish' as git submodules. 'virtualenv' works just fine when PYTHONPATH points to its repository. The only problem is 'virtualfish' requiring installation, just to show version information.