Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs tests #4

Closed
stuartpb opened this issue Oct 8, 2014 · 7 comments
Closed

Needs tests #4

stuartpb opened this issue Oct 8, 2014 · 7 comments

Comments

@stuartpb
Copy link

stuartpb commented Oct 8, 2014

Requires #3 and a .travis.yml

@stuartpb
Copy link
Author

stuartpb commented Oct 8, 2014

I think the first test should be assert($ === document);

@duhruh
Copy link

duhruh commented Oct 8, 2014

You mean the only test

@stuartpb
Copy link
Author

stuartpb commented Oct 8, 2014

You can also do assert($ == window.document); assert($ instanceof HTMLDocument);...

@stuartpb
Copy link
Author

stuartpb commented Oct 8, 2014

not to mention battalions of functional test cases

if an assertion fails in a functional test case it might even uncover a bug in the upstream implementation, maybe, although there should definitely be a fine-toothed review combing over the entire codebase locally before assuming something like that

@stuartpb
Copy link
Author

stuartpb commented Oct 8, 2014

that would be crazy, import a bunch of known failing func test cases from phantom/casper/blink to make var $ = document; have a pass rate of like 0.4%

variable assignment is so unreliable, guys, just look at these test scores

@stuartpb
Copy link
Author

hahaha we're already getting these: #7

@adambutler
Copy link
Owner

Fixed by #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants