Reduce the impact on every request #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Surprisingly, I didn't need to use signals for the tests. I'm not really sure why. |
- Use a set for faster membership test - Generate the header once at boot time - Disable the middleware if no header need to be added fixes adamchainz#21
|
The signal wasn't needed since the test client is instantiated per-test in the pytest I added a test for this that failed: It's best not to disable the middleware since users might want to change feature-policy in their tests, or (hopefully not) at run-time. I refactored to use Django's Thanks for your contributions that I've released in version 2.2.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21