Add HTTP Headers fixer for Client and RequestFactory. #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
David-Wobrock
commented
Dec 22, 2022
David-Wobrock
commented
Dec 22, 2022
| ) -> Iterable[tuple[Offset, TokenFunc]]: | ||
| if ( | ||
| isinstance(node.func, ast.Name) | ||
| and "RequestFactory" in state.from_imports["django.test"] |
There was a problem hiding this comment.
AsyncRequestFactory and AsyncClient are not handled at the moment, as the keyword arguments don't start with HTTP_ I guess they would be harder to catch 🤔
David-Wobrock
commented
Dec 22, 2022
David-Wobrock
commented
Dec 22, 2022
David-Wobrock
commented
Dec 22, 2022
David-Wobrock
force-pushed
the
feat/http-headers-rewrite
branch
from
6e5890c
to
0ca8fce
Compare
David-Wobrock
commented
Dec 23, 2022
adamchainz
force-pushed
the
feat/http-headers-rewrite
branch
2 times, most recently
from
f3c5b7f
to
5dcf1e6
Compare
adamchainz
reviewed
Feb 12, 2023
adamchainz
force-pushed
the
feat/http-headers-rewrite
branch
from
cd44676
to
9009a3f
Compare
|
Okay I’ve rewritten the implementation to resolve all noted issues. Tested against Django before your fixup commit, Sentry, and some of my clients' projects. All worked well on those. |
|
Thanks a lot for your help @adamchainz 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #271
At the moment, it's just a first draft, to get the idea.
Some cases are not handled yet, and we will have to decide how far to push the handled cases :)
Used for django/django#16401