Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why init?(name: String) was removed in 1.0.0? #35

Closed
rivera-ernesto opened this issue Apr 4, 2018 · 2 comments
Closed

Why init?(name: String) was removed in 1.0.0? #35

rivera-ernesto opened this issue Apr 4, 2018 · 2 comments

Comments

@rivera-ernesto
Copy link
Contributor

Up to 0.7.0 I could load sound files for xcassets. Now it is hard and cumbersome to manually create a URL out of a NSDataAsset.

Is there a particular reason for removing this? Would it be bad to at least keep init?(data: Data)?

Thanks!

@adamcichy
Copy link
Owner

Hi @rivera-ernesto that functionality is a part of your open pull request. It was not merged. That pull request has some unresolved issues and conflicts with current master.

@rivera-ernesto
Copy link
Contributor Author

I forgot that! Let me resolve that pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants