Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arsd #377

Open
John-Colvin opened this issue Mar 22, 2023 · 20 comments
Open

arsd #377

John-Colvin opened this issue Mar 22, 2023 · 20 comments

Comments

@John-Colvin
Copy link
Contributor

John-Colvin commented Mar 22, 2023

~/.dub/packages/arsd-official-10.9.8/arsd-official/simpledisplay.d(7222,3): Error: undefined identifier `future`

Do you have a mechanism to prevent breaking releases like this? Maybe some script that checks everything builds and then creates the tag?

@John-Colvin
Copy link
Contributor Author

it's also broken in 10.9.7 as well. 10.9.6 is ok.

@adamdruppe
Copy link
Owner

I actually did comment that out since it failed my test but apparently the tag was made before that....

Just always use master, it is the version I actually support.

@adamdruppe
Copy link
Owner

adamdruppe commented Mar 22, 2023

From master:

    /*@future*/ allowResizingMaintainingAspectRatio, // gdc 9 doesn't allow the @future thing here but that's still the intention

What compiler version you on anyway?

@John-Colvin
Copy link
Contributor Author

In order to say you support dub, I think you need to make at least the latest tag work ok. Depending on ~master means the dependency changes unpredictably, depending on a specific git commit in dub does work, but it's not how people use it. They use the versions. dub add arsd uses the versions. And so on.

@John-Colvin
Copy link
Contributor Author

dmd-2.102.0

@adamdruppe
Copy link
Owner

I don't say I support dub.

@John-Colvin
Copy link
Contributor Author

you publish a dub package called arsd-official...

@adamdruppe
Copy link
Owner

In fact, I specifically say I don't support dub. It is a gigantic pain in my ass that I'd like to see permanently deleted from all systems and all time.

It is published with the hopes that it might be useful, but with

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE, TITLE AND NON-INFRINGEMENT. IN NO EVENT
SHALL THE COPYRIGHT HOLDERS OR ANYONE DISTRIBUTING THE SOFTWARE BE LIABLE
FOR ANY DAMAGES OR OTHER LIABILITY, WHETHER IN CONTRACT, TORT OR OTHERWISE,
ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
DEALINGS IN THE SOFTWARE.

@adamdruppe
Copy link
Owner

try 10.9.9 now it might work

@John-Colvin
Copy link
Contributor Author

I understand of course, no guarantees, known by the state of cancer to cause california and so on.

I'm just wondering how to make the user experience go smoother given how they do behave.

@John-Colvin
Copy link
Contributor Author

try 10.9.9 now it might work

yeah that works, thanks :)

@adamdruppe
Copy link
Owner

Actually looks like the thing might be called __future in the mainline compiler too.

@adamdruppe
Copy link
Owner

And right now master is completely broken cuz i committed before changing branches in the middle of something lol

but at least master will get a fix p soon whereas tags sit there

@John-Colvin
Copy link
Contributor Author

John-Colvin commented Mar 22, 2023

It seems that really the answer to what to use is "some commits on master, user can work out which ones".

@adamdruppe
Copy link
Owner

Always use the latest. If it is broken, the latest actually gets fixed in a little while.

The tags are just arbitrary points where some dub user hassled me and I appeased them.

@John-Colvin
Copy link
Contributor Author

John-Colvin commented Mar 22, 2023

This isn't ideal as a user, because if I need it to work now, am I supposed to just walk back commits until I find a good one?

@adamdruppe
Copy link
Owner

If master is broken, wait 20 minutes and it is fixed.

Hell, even if dub tags are broken, ping me and I can usually cherry pick a fix there in 15-20 mins too.

@adamdruppe
Copy link
Owner

so i have a makefile that runs the local tests. it takes like a minute which is brutally slow but it tests compile across 3 compiler versions times 4 platforms (i might add a 5th soon too, i might do bsd).

mebbe a git pre-commit hook could run through all that

just sometimes i commit just to change branches lol

@adamdruppe
Copy link
Owner

git config --global --add tag.sort -version:refname

that's a neat trick

@adamdruppe
Copy link
Owner

I updated my old makefile to be on a pre commit hook at least that should keep things building before i push it lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants