Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint@2.3.0 and babel-eslint #145

Closed
tupton opened this issue Mar 7, 2016 · 2 comments
Closed

eslint@2.3.0 and babel-eslint #145

tupton opened this issue Mar 7, 2016 · 2 comments

Comments

@tupton
Copy link

tupton commented Mar 7, 2016

See eslint/eslint#5476, babel/babel-eslint#267, eslint/eslint#5494, possibly others.

The gist is that eslint@2.3.0 breaks with babel-eslint and possibly other alternative parsers.

gulp-eslint specifies ^2.0.0 which means that new installations grab 2.3.0 now. Is there any way you can pin to 2.2.x – ~2.2.0 – until eslint@2.3.0+ stabilizes?

@adametry
Copy link
Owner

adametry commented Mar 8, 2016

I'm going to hold off on publishing a version of gulp-eslint to downgrade ESLint since this is an ESLint issue specific to the use of babel-eslint (rather than an incompatibility between gulp-eslint and ESLint).

Fortunately, you can "pin" the version of ESLint that gulp-eslint uses by depending on a more specific version in your package (or any package dependent on gulp-eslint). The only restriction is that is has to be within the gulp-eslint dependency range (currently, any 2.x version).

@tupton
Copy link
Author

tupton commented Mar 8, 2016

I totally understand not pinning to 2.2.x just for babel-eslint. I hesitated even making this issue because of that. However, I am glad I did because of your second paragraph...

Fortunately, you can "pin" the version of ESLint that gulp-eslint uses by depending on a more specific version in your package (or any package dependent on gulp-eslint).

Oh that is nifty. You learn something every day. Thanks for that tip; that's a lifesaver. That restriction makes sense, but fortunately 2.2.x is in that range, so I think we're good. Again, thanks for the response and tip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants