Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi .NET version targeting #34

Open
2 of 4 tasks
adamfoneil opened this issue Sep 3, 2022 · 6 comments
Open
2 of 4 tasks

multi .NET version targeting #34

adamfoneil opened this issue Sep 3, 2022 · 6 comments
Assignees

Comments

@adamfoneil
Copy link
Owner

adamfoneil commented Sep 3, 2022

currently only NET Standard 2.0 is supported, but we need to target different .NET versions (Core 3.x+ and Framework 4.7+). The exact versions are negotiable. A few things we need here:

  • support Core 3.1+ assemblies
  • support .NET Framework assemblies
  • Integration test: Core test assembly (as embedded resource) demonstrating all attributes (Key, UniqueConstraint, Column, etc)
  • Integration test: Framework test assembly (as embedded resource), same as above

Please use branch feature/multi-targeting

@adamfoneil
Copy link
Owner Author

@usmanasfandiCheetah I believe you're already working on this. I just wanted to give a heads up I've moved this issue here.

@usmanasfandiCheetah
Copy link
Collaborator

System.Runtime 4.2.0 supports both types of assembly. Core and Standard Assembly that comes with Visual Studio version 17 and above.
System.Runtime version 4.0 only supports Standard Framework Assembly that comes with Visual Studio version 16

@usmanasfandiCheetah
Copy link
Collaborator

Both Standard and Core Framework Assemblies are now readable and getting results as its supposed to be. All the attributes are also working except for the References attributes that need to be matched with the way entity framework is handling the foreign keys and dependency constraints.

@adamfoneil
Copy link
Owner Author

@usmanasfandiCheetah I don't think there should be any EF scope work under this issue -- that should be under #29. The main thing I'm looking for here are integration tests that show DataModel creation from Core and Framework assemblies. They can be very simple models.

@adamfoneil
Copy link
Owner Author

@usmanasfandiCheetah I don't see a test in here that would demonstrate multi-targeting. I was expecting to see an integration test using assemblies as embedded resources that would build simple models in Core and Framework.

@adamfoneil
Copy link
Owner Author

@usmanasfandiCheetah just some notes on our conversation earlier. You're going to add integration test, building on what I stubbed out in the Test project for EFAssemblySources. We're not going to implement the "AO" assemblies for now

Repository owner deleted a comment Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@adamfoneil @usmanasfandiCheetah and others