Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FeatureRequest] Light theme #94

Closed
SanderSade opened this issue Feb 4, 2021 · 7 comments · Fixed by #264
Closed

[FeatureRequest] Light theme #94

SanderSade opened this issue Feb 4, 2021 · 7 comments · Fixed by #264
Labels
enhancement New feature or request

Comments

@SanderSade
Copy link

Light theme for the website, please.

While dark themes are all the rage, they are unusable for most people with astigmatism (1, 2, 3), causing eye strain and headaches. Somewhere 30..50% of the population has astigmatism.

@SanderSade SanderSade added the enhancement New feature or request label Feb 4, 2021
@tjames192
Copy link
Contributor

Light theme for the website, please.

While dark themes are all the rage, they are unusable for most people with astigmatism (1, 2, 3), causing eye strain and headaches. Somewhere 30..50% of the population has astigmatism.

Hi SanderSade, I have created an Edge extension that may help with your issue.
msportals.io Edge Extension

@SmithPlatts
Copy link

While the extension looks really neat @tjames192, it'd be great for mobile, and situations where you can't use/install extensions, for the site to support a light theme.

@tjames192
Copy link
Contributor

That is a good idea .. I hadn’t thought about that when implementing the extension. I’m not apposed to adding code to make the extension mobile friendly maybe that would be better suited for the main site or as a page.
Not sure what our options are .. maybe @adamfowlerit can comment.

@adamfowlerit
Copy link
Owner

Would love to have this option for accessibility reasons, go for it!

@jlaundry
Copy link
Contributor

jlaundry commented Feb 13, 2024

Looking at the source jekyll theme, there doesn't appear to be a Light variant... so instead I've had a go at creating one.

Live demo: https://jlaundry.github.io/msportals.io/

Thoughts/feedback please!

Instead of creating an explicit light/dark mode button, the way I've done this respects the user's browser setting, so if you're still seeing the Dark theme, you'll need to change your OS/Browser setting.

@SanderSade
Copy link
Author

Thoughts/feedback please!

Works very well for me. Thank you!

@adamfowlerit
Copy link
Owner

Works great, but I'd also love to see a user controllable toggle - use the system default as the default msportals.io exp though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants