Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an extra column to the
rich
Console output for displaying the time.Changes
馃挕 In order to display a time, the logging handler needs a formatter that specifies a
datefmt
. This is needed so that the formatter can callformatTime
, and we use that value to display!DjangoRequestHandler.__init__
set a default formatter if none is passed in, else use passed in formatterDjangoRequestHandler.emit
callformatTime
on its formatter and adds extra column to log outputDjangoRequestHandler.__init__
tests 馃ИTesting
HH:MM:SS
django_rich_logging
handler here. Time format will be whatever the formatter'sdatefmt
setting is."formatter": "verbose",
, the time format will beYYYY-MM-DD HH:MM:SS
Notes, Questions, & Follow-up
django_rich_logging
handlerMethod
and text colorfreezegun
?