Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.html extension duplication in 6.1.0 #195

Closed
ittaibaratz opened this issue Mar 4, 2022 · 6 comments
Closed

.html extension duplication in 6.1.0 #195

ittaibaratz opened this issue Mar 4, 2022 · 6 comments

Comments

@ittaibaratz
Copy link

ittaibaratz commented Mar 4, 2022

Hello there!

We have a dependency bot in our repo and in the PR that updates mochawesome-report-generator from version 6.0.1 to 6.1.0, I've noticed that the report file created has html twice in its filename. Is this an expected change?

Thank you!

$ marge cypress/reports/mochawesome-merged.json -o ./cypress/reports -f mochawesome.html --inline
��� Reports saved:

 /home/jenkins/workspace/exc-pueblo_PR-163/cypress/reports/mochawesome.html.html
@ittaibaratz ittaibaratz changed the title html name regression in 6.1.0 html duplication in 6.1.0 Mar 4, 2022
@ittaibaratz ittaibaratz changed the title html duplication in 6.1.0 .html extension duplication in 6.1.0 Mar 4, 2022
@adamgruber
Copy link
Owner

Yes, the reporter no longer strips out .html or .json when used in reportFilename. You can simply update your command to this:

marge cypress/reports/mochawesome-merged.json -o ./cypress/reports -f mochawesome --inline

@ittaibaratz
Copy link
Author

ittaibaratz commented Mar 4, 2022

@adamgruber thanks for confirming. In my case its a bit tricky because our CI/CD hosts over 100 applications and I can't force them all to upgrade (Or change their command) at the same time, but we can add some logic to strip out double HTMLs. Thanks!

@adamgruber
Copy link
Owner

So thinking on this more it's a breaking change and should have been a major version bump. I'm going to consider it a regression and put out a bug fix.

@ittaibaratz
Copy link
Author

Awesome, thanks @adamgruber !

@adamgruber
Copy link
Owner

Fixed in mochawesome 7.1.2 (mochawesome-report-generator 6.1.1)

@ittaibaratz
Copy link
Author

@adamgruber the dependency bot picked up 6.1.1 and reporting is back. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants