Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency issue #5

Closed
nwalke opened this issue Dec 18, 2017 · 2 comments
Closed

Dependency issue #5

nwalke opened this issue Dec 18, 2017 · 2 comments

Comments

@nwalke
Copy link

nwalke commented Dec 18, 2017

I have this:

import React from "react";
import ReactDOM from "react-dom";
import { renderSync } from 'sass-extract';

const theme = renderSync(
    { file: './theme.scss' },
    { plugins: ['sass-extract-js'] }
).vars;

My theme.scss file exists and just has one variable defined in it. When I try to start my project I get this:

./node_modules/node-sass/lib/binding.js
19:9-37 Critical dependency: the request of a dependency is an expression

./node_modules/sass-extract/lib/pluggable.js
52:17-32 Critical dependency: the request of a dependency is an expression

This seems to happen with sass-extract version 2 and 1.0.1.

Am I missing something? Any help or assistance would be much appreciated!

@nwalke
Copy link
Author

nwalke commented Dec 19, 2017

I think I had sass-extract version 2, so I ran npm install sass-extract@^1.0.1 and verified that it's 1.0.1 in my node_modules directory, but I still get the same error.

Here's a small capture of what I see in the browser since I didn't include that before.
screen shot 2017-12-19 at 11 13 37 am

@nwalke
Copy link
Author

nwalke commented Dec 19, 2017

I was way off base here. My bad :)

@nwalke nwalke closed this as completed Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant