Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create password protected archives #61

Open
sepehr1014 opened this issue May 31, 2015 · 14 comments
Open

Create password protected archives #61

sepehr1014 opened this issue May 31, 2015 · 14 comments

Comments

@sepehr1014
Copy link

How can we set password when creating archives?

@sepehr1014
Copy link
Author

If this can't be done, can you point out which parts need to be modified in order to implement this feature?

@sepehr1014
Copy link
Author

@adamhathcock It seems this project is not actively maintained. We're working on a big project and we had plans to use SharpCompress as part of it ...

@adamhathcock
Copy link
Owner

I'm still here but I'm not actively working on it. Others have contributed and asked questions and I try to answer them. However, my focus is elsewhere at the moment.

As far as creating passwords, you'd probably want to modify the WriterFactory, as a starting point, to take the password. Then implement it on ZipWriter or other writers. Then the ArchiveFactory would do the same.

@alex4998
Copy link

I just reviewed the code. As far as I understand it is a matter of using PkwareTraditionalCryptoStream in the streams chain for writing data. It is, of course, if that class is fully implemented for encryption. I see this question was asked long ago. I need this too. Did somebody already did it or started doing it? I'm thinking about implementing this part but I would like to avoid double work and reuse what's already done but not added to the project. Please, let me know.

@adamhathcock
Copy link
Owner

I doubt anyone is working on it. Please do and submit a pull request :)

@dos-ise
Copy link

dos-ise commented Jul 17, 2017

Has there been any progress on this? I would need this feature....

@adamhathcock
Copy link
Owner

You’re welcome to add it yourself.

@dos-ise
Copy link

dos-ise commented Jul 17, 2017

I have tried something. But having problems with the encryption data :/
You can take a look at it under -> Commit 2482769e

@dos-ise
Copy link

dos-ise commented Jul 26, 2017

Did you take a look at my commit?

@adamhathcock
Copy link
Owner

I didn't because I'm on vacation and I have no idea how to view whatever you're referring to.

Please, make a pull request if you have something for review.

@dos-ise
Copy link

dos-ise commented Jul 27, 2017

Forget that :)

@adamhathcock
Copy link
Owner

Sorry, I would really like a diff. Pull Requests do work with a proper fork of the repo.

@dos-ise
Copy link

dos-ise commented Jul 27, 2017

#284

now it has worked ^^
I'm just stupid :)

@Looooong
Copy link
Contributor

Is there any problem on the zip_encryption branch? Perhaps I can look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants