Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Request Caching #29

Closed
adamint opened this issue Dec 29, 2018 · 8 comments
Closed

Implement Request Caching #29

adamint opened this issue Dec 29, 2018 · 8 comments

Comments

@adamint
Copy link
Owner

adamint commented Dec 29, 2018

(this should be very simple)
@adamint
Copy link
Owner Author

adamint commented Dec 29, 2018

ok this is extremely annoying to test

@adamint
Copy link
Owner Author

adamint commented Dec 29, 2018

@molikuner If you don't mind, I'd like someone else reviewing/testing my cache implementation (because if something goes wrong with requesting, that endpoint object can't be used). Would you be able to pull the changes and review it?

@molikuner
Copy link
Collaborator

Yes I'll look over it.

@molikuner
Copy link
Collaborator

molikuner commented Dec 29, 2018 •
edited
Loading

Does Spotify have Cache-Control on all endpoints?

@molikuner
Copy link
Collaborator

Shouldn't we give the user an option to disable caching?

@adamint
Copy link
Owner Author

adamint commented Dec 29, 2018

Yeah, we should

@adamint
Copy link
Owner Author

adamint commented Dec 29, 2018

Added

@adamint
Copy link
Owner Author

adamint commented Dec 29, 2018

Though I'm really not sure why you'd want to disable caching

@adamint adamint closed this as completed Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamint @molikuner