Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Import (Append) erases all alerts and doesn't add alert being imported. #14

Closed
iatethedinosaurs opened this issue Jan 14, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@iatethedinosaurs
Copy link

Hello, loving the new update! I've been having a blast customizing my alerts using regex. I really appreciate your work!

I've run into a problem while trying to import alerts. Clicking the Import (Append) button erases the entire notification list and doesn't actually add the notification it was supposed to.

I thought it might just be a visual bug, but restarting the Runelite client, the notification list is indeed empty.
I also thought that it might be just a certain notification types being imported that could be causing it, but it's consistent across all notification types

Steps to reproduce:

  1. Click Import on main panel
  2. Paste any exported notification ex: [{"type":"NotificationFiredAlert","message":"Crystal impling is in the area","regexEnabled":false,"enabled":true,"name":"Crystal Impling","debounceTime":0,"notifications":[{"type":"ScreenFlash","color":"#46FF0000","flashNotification":"SOLID_TWO_SECONDS","fireWhenFocused":false}]}]
  3. Click Import (Append)

It may be worth mentioning that Import (Overwrite) is working properly.

@adamk33n3r
Copy link
Owner

Hey thanks for reporting this and for the kind words! I must have missed something when I redid the way notifications are saved automatically. I'll hopefully be able look into this today.

@adamk33n3r
Copy link
Owner

This has been PR'd to the plugin hub runelite/plugin-hub#3769 and I've asked for it to be looked at urgently since it can wipe data without question so hopefully it'll be merged in soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants