New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Operator Classified As Cast #94
Comments
Balls. Thanks, i'll try and figure out how to fix that. |
This is one of those cases where i wish I'd written a more generic operator
|
Ok, i think i fixed this. @adamkennedy : Can you please look at the commit to verify that the change looks sane for this issue? Further, can you please make another issue elaborating on what you mean with operator/operand context/method? @thaljef : This issue has been present since roughly 2006. As such, i hope you don't mind if this fix will be released with 1.222, and 1.220 to be released unchanged from the dev release. |
@wchristian: No problem. |
Initially reported at Perl-Critic#604, PPI was (prior to 1.222) treating as a cast certain operators, namely multiplication (`*`) (<Perl-Critic/PPI#94>) and modulus (`%`) and bitwise-and (`&`) (<Perl-Critic/PPI#119>). Fixed upstream but added some tests to cover all bases. Signed-off-by: Amory Meltzer <Amorymeltzer@gmail.com>
Initially reported at Perl-Critic#604, PPI was (prior to 1.222) treating as a cast certain operators, namely multiplication (`*`) (<Perl-Critic/PPI#94>) and modulus (`%`) and bitwise-and (`&`) (<Perl-Critic/PPI#119>). Fixed upstream but added some tests to cover all bases.
Initially reported at #604, PPI was (prior to 1.222) treating as a cast certain operators, namely multiplication (`*`) (<Perl-Critic/PPI#94>) and modulus (`%`) and bitwise-and (`&`) (<Perl-Critic/PPI#119>). Fixed upstream but added some tests to cover all bases.
In the following expression, the
*
operator is misclassified as a cast:Parse tree (PPI version 1.219_001)
NB: Adding whitespace after the
*
operator produces the correct result.This was originally reported as Perl-Critic/Perl-Critic#604
The text was updated successfully, but these errors were encountered: