Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Fixing typos/spellchecking/improving game text #30

Closed
bloodyshade opened this issue Apr 12, 2022 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@bloodyshade
Copy link
Contributor

ATTN

If you are planning to implement this feature, all tests must pass. Failure to do so will have the feature rejected until they do.

No feature is allowed to "require" payment of any kind for the player to be able to access. They can how ever be restricted by level, skill, plane, gold or any other existing "gate" in game.

If this feature implements or makes use of timers, you must make sure the player can log out, in, navigate to any page and come back and see the timer still running.

Is your feature request related to a problem? Please describe.
No.

Describe the solution you'd like
Spend time as possible improving the text in the game, including fixing typos.

Describe alternatives you've considered
The only alternative in this case would be to leave things as is, and while that is fine for the most part, I would like to contribute as I can to the game's overall improvement.

Additional context
Add any other context or screenshots about the feature request here.

How would you as the player benefit from this additional feature?
Improving the readability of the game as a whole would benefit every player. (Personally, perfectionism is a curse.)

How would the community benefit from this feature?
Improving the readability of the game as a whole would benefit every player.

Does this feature already exists and if so are you expanding upon it?
Yes, mostly just fixing typos and improving text where possible.

Are you planning to implement this or are you expecting me to?
I'm planning on working on this myself as time allows.

Does this feature break any existing feature?
It should not.

Does this feature fix and existing bug?
Only to the extent that I might find things wrongly named in the code (for example invalid variable names) in which case those are changed to the supposedly correct ones. At which point we can further deliberate/discuss before PRs are accepted.

@AdamKyle
Copy link
Owner

Merged and accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants