Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad logic strikes again! #13

Closed
adamlundrigan opened this issue Jul 30, 2014 · 0 comments
Closed

Bad logic strikes again! #13

adamlundrigan opened this issue Jul 30, 2014 · 0 comments
Assignees
Labels
Milestone

Comments

@adamlundrigan
Copy link
Owner

save short-circuits at the first failed extension due to this little mistake:

$result = true;
foreach ( $this->getExtensions() as $name => $ext ) {
    $result = $result && $ext->save($entity);
}

&& short-circuits when $result is false.

@adamlundrigan adamlundrigan self-assigned this Jul 30, 2014
@adamlundrigan adamlundrigan added this to the 1.1.1 milestone Jul 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant