Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set PHP 5.4 as requirement #9

Open
ghost opened this issue Jul 4, 2014 · 1 comment
Open

Set PHP 5.4 as requirement #9

ghost opened this issue Jul 4, 2014 · 1 comment
Labels
question
Milestone
2.0.0

Comments

@ghost
Copy link

ghost commented Jul 4, 2014

If we set PHP 5.4 as requirement, we could make usage of traits.

I think PHP 5.4 is very common on the most web hosters now. It was already released on 1st March 2012.
@ghost ghost mentioned this issue Jul 4, 2014
Closed
@adamlundrigan
Copy link
Owner

This is always a question of balance. IMO you are right that the vast majority of people are no longer using <= 5.4, but is it worth excluding those who do just to save ~30 lines of boilerplate code? That said, 5.3.x is EOL this month so those still using it should have no reasonable expectation that new code will be fully compatible with it. I'm leaning towards agreeing with you and bumping the minimum version to 5.4.0...

@adamlundrigan adamlundrigan added this to the 2.0.0 milestone Jul 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@adamlundrigan