Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/book/search Pagination #27

Closed
2 tasks done
AdamMcAdamson opened this issue Nov 21, 2022 · 2 comments
Closed
2 tasks done

/book/search Pagination #27

AdamMcAdamson opened this issue Nov 21, 2022 · 2 comments

Comments

@AdamMcAdamson
Copy link
Owner

AdamMcAdamson commented Nov 21, 2022

Right now, we return the first X number of books that match the query. We probably want to enable full pagination.
It might be easiest to implement with the limit/offset SQL clauses.

If we go that route:

  • Implement Limit/Offset Pagination
  • Add offset query parameter
@KryptonC-02
Copy link
Collaborator

KryptonC-02 commented Nov 21, 2022

search class modified to facilitate, only major change is that it needs to be passed a page number to determine the offset.
Couldn't find where to take it from there, as I couldn't figure out where the class methods were called.

@AdamMcAdamson
Copy link
Owner Author

AdamMcAdamson commented Nov 28, 2022

All that is left is to Implement is a way for the frontend to navigate to the Next/Prev/X page, should there be one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants