VSphere tags in inventory

[Atadilo]

I'm using terraform with VSphere provider.

$ terraform version
Terraform v0.11.1
+ provider.vsphere v1.1.1

And I use tags : https://www.terraform.io/docs/providers/vsphere/d/tag.html

In my terraform.tfstate file the tag names are not directly in the resources.

    "vsphere_virtual_machine.twelve": {
        "type": "vsphere_virtual_machine",
        "primary": {
            "id": "422cfa4a-c6bb-3405-0335-2d9b2034405f",
            "attributes": {
                "default_ip_address": "10.20.30.50",
                "tags.#": "1",
                "tags.1357913579": "urn:vmomi:InventoryServiceTag:00000000-0001-4957-81fa-1234567890ab:GLOBAL"
            }
        }
    },
    "data.vsphere_tag.testTag1": {
        "type": "vsphere_tag",
        "primary": {
            "id": "urn:vmomi:InventoryServiceTag:00000000-0001-4957-81fa-1234567890ab:GLOBAL",
            "attributes": {
                "name": "testTag1"
            }
        }
    }

To solve this, I create a map of ID => name of all resources.
And during "inventorize tags", I look for "ID" in the map to replace with tag name.

[adammck]

This is great, thanks very much for tackling this. This is the first provider I've seen to work in a way other than here's a list tags for each resource. Just a couple of comments.

[adammck]

Please fix the indentation in this file. It's not caught by gofmt because it's a humungous JSON string.

[adammck]

Please rename this to something a bit more descriptive, and/or add a docstring. I know this is a private method, but I'm having trouble understanding exactly what it does.

[Atadilo]

I modified the files, is that enough?

[uberjew666]

This functionality is brilliant.
I do hope this gets merged soon.

[adammck]

Thanks very much for this patch! I suspect that many other providers do/will work like this, so this will be a useful template in addition to the functionality. Sorry about the very slow review.