Feature: System Color Scheme #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good stuff! |
adamrushy
reviewed
May 5, 2022
...tributor.xcodeproj/xcuserdata/tunde.adegoroye.xcuserdatad/xcschemes/xcschememanagement.plist
Outdated
Show resolved
Hide resolved
| case .dark: | ||
| return "🌚 Dark" | ||
| case .system: | ||
| return "📱 System" |
|
|
||
| final class AppColorSchemeManager: ObservableObject { | ||
|
|
||
| @AppStorage("currentColorScheme") var colorScheme: Int = AppColorScheme.allCases.first!.rawValue // Force unwrap YOLO 🤪 |
tunds
force-pushed
the
feature/color-scheme-support
branch
from
aab4dbb
to
6bcd8d2
Compare
…e app, also did some refactoring on the setting screen to break out views shown in the list.
tunds
force-pushed
the
feature/color-scheme-support
branch
from
6bcd8d2
to
f9f74b0
Compare
|
@adamrushy All those issues should be resolved now 👍🏾 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added system settings for light, dark, and system theme for the entire app, also did some refactoring on the setting screen to break out views shown in the list.
