Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added AppReview Request #9

Merged
merged 1 commit into from May 7, 2022
Merged

Added AppReview Request #9

merged 1 commit into from May 7, 2022

Conversation

StewartLynch
Copy link
Contributor

App Review Request

Added a static function on an AppReviewRequest enum that will request an app review when the SettingsView appears.
The attempt to present the app review request will only be made if there are certain conditions met.

  1. The number of times the SettingsView appears had reached a threshold set in the static property of the enum
  2. The app version and build have not changed since last appearance

The function can be called at any point in the app where it is deemed appropriate. I just added it to the SettingsView appearance for the time being, but it can be moved anywhere in the future.

adamrushy
adamrushy approved these changes May 7, 2022
View reviewed changes
Copy link
Owner

@adamrushy adamrushy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work adding this feature! 🙌🏼

@adamrushy adamrushy merged commit d659bd4 into adamrushy:main May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrushy adamrushy adamrushy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@StewartLynch @adamrushy