Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong processing (), [] in log string #12

Closed
kodemi opened this issue Apr 23, 2013 · 1 comment
Closed

Wrong processing (), [] in log string #12

kodemi opened this issue Apr 23, 2013 · 1 comment
Labels
bug

Comments

@kodemi
Copy link

kodemi commented Apr 23, 2013

Tested in Chrome 27.0.1453.12 dev, Firefox 19.0.2

log( "*(data)*")

Result: (data)
Expected: (data)

log("_(data)_")

Result: (data)
Expected: (data)

log('[c="color: red"](data)[c]')

Result: c='color: red'[c]
Expected: (data) in red color

log("*[data]*")

Result: [data]
OK

log("_[data]_")

Result: [data]
OK

log('[c="color: red"][data][c]')

Result: [c='color: red'][data][c]
Expected: [data] in red color
craniumslows pushed a commit to craniumslows/log that referenced this issue Apr 30, 2013
Fixed Regex Errors Issue adamschwartz#12
4b1f5fc 
The regex wasn't escaping the parenthesis and it was only looking for a
left not the right.  Confirmed working in

Chrome  26.0.1410.65
Project broken for Firefox 20 and Webkit nightly 149402
craniumslows pushed a commit to craniumslows/log that referenced this issue May 1, 2013
Issue adamschwartz#12 Regex changes
e5cde5e 
Confirmed working with Firefox 20 + Firebug & Chrome 26. Couldn't get
it to run properly on Webkit nightly.

Regex isn't escaping the ) parenthesis or the bracket which is why it
wouldn't match.  After thinking about it and submitting a req for an
altered regex I realized that for these functions they don't care
what's in the backreference we just want to style it all.
@adamschwartz adamschwartz mentioned this issue Jun 6, 2013
Closed
@adamschwartz adamschwartz mentioned this issue Sep 30, 2013
Closed
@adamschwartz
Copy link
Owner

These have nearly all been fixed with 18c5d89 and a075098.

The last open bug has been moved #22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamschwartz @kodemi