Amended Pull Request #14
Conversation
The regex wasn't escaping the parenthesis and it was only looking for a left not the right. Confirmed working in Chrome 26.0.1410.65 Project broken for Firefox 20 and Webkit nightly 149402
Confirmed working with Firefox 20 + Firebug & Chrome 26. Couldn't get it to run properly on Webkit nightly. Regex isn't escaping the ) parenthesis or the bracket which is why it wouldn't match. After thinking about it and submitting a req for an altered regex I realized that for these functions they don't care what's in the backreference we just want to style it all.
I tested this in FF 20 with Firebug and Chrome 26 and it worked as expected. Issue provided the JS used http://js2coffee.org/ to just translate it and it worked just fine.
|
Let me know if I'm failing at this. 👊 |
I changed up the regex so that it will match with an opening single ' or double " quote. confirmed this works in Chrome 26 and FF 20 with Firebug
…Variable}[c]") Requested in comments of Issue adamschwartz#11
|
Hey @craniumslows, thanks for all of your help so far. I'd like to merge these changes, particularly the parts which address #11 and #12. However, I'm seeing several issues when I test locally in Chrome 27.0.1453.93 on Mac OS. (See the screenshot below.) If you can address these regressions I'd be happy to merge. Also, note that the |
|
Hi Sorry about that ill be able to fix this late Sunday or early Monday. Thanks for emailing / messaging me! -craniumslows — On Wed, Jun 5, 2013 at 7:56 PM, Adam Schwartz notifications@github.com
|
I changed it up to use the more greedy .* and that will match anything inside of reference which is what we want anyway.
Apologies for making a little mess. Confirmed it works with FF and Chrome isn't happy with WebKit Nightly