Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Table Log #39

Closed
amilajack opened this issue Jul 10, 2016 · 4 comments
Closed

PR: Table Log #39

amilajack opened this issue Jul 10, 2016 · 4 comments

Comments

@amilajack
Copy link

Willing to make a PR for a feature similar to console.table(). Would this pr be welcome?

@adamschwartz
Copy link
Owner

as i understand it, console.table does stuff like this:

image

what would ur pr do?

@amilajack
Copy link
Author

I'd make an api that's much more easy to use. So if a user simply logged an object, the output would be something like:

{
 name: 'john',
 age: 43,
 eyeColor: black
}

    Name: john

    Age: 43

...so forth.

This is especially useful for arrays of objects.

@adamschwartz
Copy link
Owner

One of the goals of this project is keeping it small. The current version as of the time of this writing is 2.13 KB (log.min.js @ v0.3.0).

It’s hard to say which PRs I would or wouldn’t accept without seeing them, but I will say that if you can keep the change small yet accomplish a significant improvement over the existing features of log and console.table for a clear use-case, then I’d certainly consider it. I leave it up to you!

And of course you’re always welcome to fork log into something called console.betterTable and ship it as an accompanying lib. And if it plays nicely with log I’d be happy to list it in the README as an accompanying lib. Good luck!

@amilajack
Copy link
Author

I see. Thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants