Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other language and jalali calendar #169

Open
2 of 6 tasks
AmirMohammadDehghan opened this issue Mar 31, 2024 · 12 comments
Open
2 of 6 tasks

Support other language and jalali calendar #169

AmirMohammadDehghan opened this issue Mar 31, 2024 · 12 comments

Comments

@AmirMohammadDehghan
Copy link

AmirMohammadDehghan commented Mar 31, 2024

Feature Description

Wow your package is really fantastic but it didn't support jalali or shamci calender and in our country miladi calender to book appointments not useful

The Ideal Solution

you can add jalali calender in your project and if you needed my help you can have it bro

The Current Solution

I suggest you to use this I found some useful resources:
https://pypi.org/project/django-jalali-date/
https://stackoverflow.com/questions/42182989/jalali-calendar-in-fullcalendar
https://github.com/mzangeneh/fullcalendar-shamsi

Additional Context

Add any other context or screenshots about the feature request here.

Are you willing to help with the implementation?

  • Yes, I will contribute to the implementation of this feature.
  • No, I can't assist with the implementation, but I can provide feedback and guidance.

Priority

How important is this feature to you?

  • Critical
  • High
  • Medium
  • Low
@adamspd
Copy link
Owner

adamspd commented Apr 1, 2024

Hi @AmirMohammadDehghan,

Thanks for the awesome feedback! Adding a Jalali calendar sounds like a great idea, especially for users in Iran and Afghanistan. I'm not too familiar with it, so it'd be fantastic if you could help out by making a pull request with the necessary changes. I can help review and guide you through it if needed.

What do you think?

@AmirMohammadDehghan
Copy link
Author

Hi @adamspd I am really interesting to contribute in this project in my free times and for this I need more information about how logic of this system work and structure of project and review codes
for start integrate jalali calendrer before start we should think about how manage and make choice to use this both calendars since we need differ models and views and template and assets files and we should decide to use new models and view or we should integrate this present model and view with jalali

what do you think about this?

@adamspd
Copy link
Owner

adamspd commented Apr 2, 2024

So, you mean that in order to integrate it, new models are required ?

I will create a diagram of the models and of some use cases for you so you may have a better understanding.

@AmirMohammadDehghan
Copy link
Author

Thanks @adamspd I am not sure but maybe we should do it
OK I am waiting for you bro

@AmirMohammadDehghan
Copy link
Author

I checked again model you used date time field for save dates but I think for jalai calendar is better to use jalali date field it have package and jalali calender week days start from Saturday we should be careful full about it

@adamspd
Copy link
Owner

adamspd commented Apr 2, 2024

I might have a few ideas, let me think about them and I will let get back to you once they are clearer in my head. In the meantime, if you have any questions, other than this issue, let me know.

You're used to coding with python, right ?

@AmirMohammadDehghan
Copy link
Author

OK I am waiting

Yes I am coding about 4 years as python programmer and 2 years I am working at web development as django programmer
Yea I am familiar with python

@AmirMohammadDehghan
Copy link
Author

If I had other questions I'll ask you

@adamspd
Copy link
Owner

adamspd commented Apr 5, 2024

I will get back to you during the weekend.

@AmirMohammadDehghan
Copy link
Author

Ok

@adamspd
Copy link
Owner

adamspd commented Apr 10, 2024

Sorry it took me so long to respond to you. The only thing I can think of that would be a better solution would be to create an entirely separate package for jalali calendar. Unless you have a better idea.

I use fullcalendar to display the calendar, and while searching I found this equivalent of full calendar here. Not sure if it works 100%, but I wouldn't know until I try it locally. If it works, I'll let you know where you're going to find the code, and you can test it and add more to it if you'd like.

@AmirMohammadDehghan
Copy link
Author

AmirMohammadDehghan commented Apr 11, 2024

Good I'd waiting for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants