[Bug]heap-buffer-overflow in function fouBytesToInt():AudioFile.h:1196

[Asteriska001]

Description

A heap-buffer-overflow was discovered in function fouBytesToInt():AudioFile.h:1196
The issue is being triggered in function getIndexOfChunk()

Version

Version 004065d (Lastest commit)

Environment

Ubuntu 18.04, 64bit

Reproduce

Command

git clone the Lastest Version firstly.
mkdir build
cd build && cmake ..
g++ -g -fsanitize=address -o valibin a.cpp AudioFile.h
./ poc

program

#include <iostream>
#define _USE_MATH_DEFINES
#include <cmath>
#include "AudioFile.h"

namespace examples

{

    void writeSineWaveToAudioFile();

    void loadAudioFileAndPrintSummary(char *);

    void loadAudioFileAndProcessSamples(char *);

} // namespace examples

int main(int argc, char **argv)

{
        examples::loadAudioFileAndPrintSummary(argv[1]);
        examples::loadAudioFileAndProcessSamples(argv[1]);
}





namespace examples

{

    void writeSineWaveToAudioFile()

    {
  

        AudioFile<float> a;

        a.setNumChannels(2);

        a.setNumSamplesPerChannel(44100);



        //---------------------------------------------------------------

        // 2. Create some variables to help us generate a sine wave



        const float sampleRate = 44100.f;

        const float frequencyInHz = 440.f;



        //---------------------------------------------------------------

        // 3. Write the samples to the AudioFile sample buffer



        for (int i = 0; i < a.getNumSamplesPerChannel(); i++)

        {

            for (int channel = 0; channel < a.getNumChannels(); channel++)

            {

                a.samples[channel][i] = sin((static_cast<float>(i) / sampleRate) * frequencyInHz * 2.f * M_PI);

            }

        }



        //---------------------------------------------------------------

        // 4. Save the AudioFile



        std::string filePath = "sine-wave.wav"; // change this to somewhere useful for you

        a.save("sine-wave.wav", AudioFileFormat::Wave);

    }



    //=======================================================================

    void loadAudioFileAndPrintSummary(char *file)

    {
        const std::string filePath = std::string(file);

        AudioFile<float> a;

        bool loadedOK = a.load(filePath);



        /** If you hit this assert then the file path above

         probably doesn't refer to a valid audio file */

        assert(loadedOK);



        //---------------------------------------------------------------

        // 3. Let's print out some key details



        std::cout << "Bit Depth: " << a.getBitDepth() << std::endl;

        std::cout << "Sample Rate: " << a.getSampleRate() << std::endl;

        std::cout << "Num Channels: " << a.getNumChannels() << std::endl;

        std::cout << "Length in Seconds: " << a.getLengthInSeconds() << std::endl;

        std::cout << std::endl;

    }



    //=======================================================================

    void loadAudioFileAndProcessSamples(char *file)

    {

        //---------------------------------------------------------------

        std::cout << "**********************" << std::endl;

        std::cout << "Running Example: Load Audio File and Process Samples" << std::endl;

        std::cout << "**********************" << std::endl

                  << std::endl;



        //---------------------------------------------------------------

        // 1. Set a file path to an audio file on your machine

        const std::string inputFilePath = std::string(file);



        //---------------------------------------------------------------

        // 2. Create an AudioFile object and load the audio file



        AudioFile<float> a;

        bool loadedOK = a.load(inputFilePath);



        /** If you hit this assert then the file path above

         probably doesn't refer to a valid audio file */

        assert(loadedOK);



        //---------------------------------------------------------------

        // 3. Let's apply a gain to every audio sample



        float gain = 0.5f;



        for (int i = 0; i < a.getNumSamplesPerChannel(); i++)

        {

            for (int channel = 0; channel < a.getNumChannels(); channel++)

            {

                a.samples[channel][i] = a.samples[channel][i] * gain;

            }

        }



        //---------------------------------------------------------------

        // 4. Write audio file to disk



        //std::string outputFilePath = "quieter-audio-filer.wav"; // change this to somewhere useful for you

        //a.save(outputFilePath, AudioFileFormat::Aiff);

    }

} // namespace examples

POC file at the bottom of this report.

ASAN Report

POC

POC

Any issue plz contact with me:
asteriska001@gmail.com
OR:
twitter: @Asteriska8

[adamstark]

Hi there, thanks for this. What format is the file you are trying to load in?

[adamstark]

Nevermind - i think I understand now. I've made some changes that stop this kind of thing from happening. Those changes should be on develop now :) If you had time to verify I'd appreciate it!