Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array of Labels and their text #23

Closed
Joebeazelman opened this issue Oct 26, 2022 · 1 comment
Closed

Array of Labels and their text #23

Joebeazelman opened this issue Oct 26, 2022 · 1 comment

Comments

@Joebeazelman
Copy link

Joebeazelman commented Oct 26, 2022

Awesome tool! The conversion works almost flawlessly with the exception of one issue. For the first key, there are only five (5) entries in the labels field while it's nine for all the other keys. I've enclosed the entire file for your review.

"keys": [
    {
      "color": "#413c2c",
      "labels": [
        null,
        null,
        null,
        null,
        "←"
      ],
      "textColor": [
        null,
        null,
        null,
        null,
        null
      ],
      "textSize": [],
      "default": {
        "textColor": "#f1ecda",
        "textSize": 7
      }
...
     {
      "color": "#413c2c",
      "labels": [
        null,
        "!",
        null,
        null,
        null,
        null,
        null,
        "1",
        null,
        null,
        "BLK"
      ],
      "textColor": [
        null,
        null,
        null,
        null,
        null
      ],

vic20-layout.json.zip

@adamws
Copy link
Owner

adamws commented Dec 22, 2022

Thanks for reporting, I checked and it looks like that is how ijprest/kle-serial implements it. Right now I'm not considering patching that.

@adamws adamws closed this as completed Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants