Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infinite loop from lastnevertallest #47

Closed
adamwulf opened this issue Jun 3, 2012 · 1 comment
Closed

infinite loop from lastnevertallest #47

adamwulf opened this issue Jun 3, 2012 · 1 comment

Comments

@adamwulf
Copy link
Owner

adamwulf commented Jun 3, 2012

http://welcome.totheinter.net/columnizer-jquery-plugin/#comment-14432

I you select “lastNeverTallest” and you only have one item with the class “dontsplit” f.ex. one li element, you run into an infinite loop an the browser crashes because of this line of code:

if(options.lastNeverTallest && lastIsMax){
// the last column is the tallest
// so allow columns to be taller
// and retry
targetHeight = targetHeight + 30;
if(loopCount == maxLoops-1) maxLoops++;
}

maxLoops will grow to infinite.. And the single item will be in the last column.

@adamwulf
Copy link
Owner Author

fixed in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant