Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subshell does not work #51

Open
Ejsstiil opened this issue Mar 29, 2023 · 9 comments
Open

Subshell does not work #51

Ejsstiil opened this issue Mar 29, 2023 · 9 comments

Comments

@Ejsstiil
Copy link

Ejsstiil commented Mar 29, 2023

When Ctrl+O is pressed the panels hide but you can't type anything in the subshell - there is no a subshell. Is this feature supported on the Windows build?
Tested in wt, powershell, cmd

@adamyg
Copy link
Owner

adamyg commented Mar 30, 2023

subshell is not enabled/suitable under a windows console.

@Ejsstiil
Copy link
Author

Ejsstiil commented Apr 1, 2023

Strange assumption as this is the crucial thing about MC. The benefit of having a subshell under mc is obvious. Without that it is not the mc as we knows it(linux). Could you please add the support of it but leave it disabled by default?

@adamyg
Copy link
Owner

adamyg commented Apr 9, 2023

Sharing the window's console is problematic, enabling sub-shell requires specific job and terminal control features of the underlying terminal, plus the sub-shell command(s) need to be well behaved console application's. Window's 10 Pseudo Console/ConPTY may provide a solution (winxsh), only with reasonable devl effort.

@Ejsstiil
Copy link
Author

I understand, that's bad news... Would be possible to do it in some alternative way - that the mcwin will launches two consoles so one will be consumed by mcwin and the second one would be brought-up by ctrl+o ? The only thing would be just to maintain the current pwd in both?
Just thoughts.

@adamyg
Copy link
Owner

adamyg commented Apr 16, 2023

would need to re-implement: src/subshell/common.c, using ConPTY for the sub-shell

@kjdro
Copy link

kjdro commented Dec 20, 2023

how about using git bash ?
i can run mc from there

@adamyg
Copy link
Owner

adamyg commented Jan 17, 2024

Still considering, effort for a feature i generally disable under Linux and other hosts.
Tabbed terminal as alt?

@AndreKR
Copy link

AndreKR commented May 6, 2024

Still considering, effort for a feature i generally disable under Linux and other hosts.

Then what do you even use mc for? I generally use it to navigate to the directory where I want to execute commands. You use it for file operations (copy, move) only?

@AndreKR
Copy link

AndreKR commented May 6, 2024

Here's an idea that should be quick(er) to implement: There is already a working command prompt if you have it enabled (Options > Layout > Command prompt). Maybe when it's disabled (which is necessary to enable quick navigation by typing) on Ctrl+O you could show that same command line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants