Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand styling options for tabs #137

Closed
LennysLounge opened this issue Jun 3, 2023 · 4 comments · Fixed by #139
Closed

Expand styling options for tabs #137

LennysLounge opened this issue Jun 3, 2023 · 4 comments · Fixed by #139
Labels
enhancement New feature or request

Comments

@LennysLounge
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The currently available styling options dont quite allow me to create a styling that closely follows the rest of the egui styling.

I have put together a simple panel to show what i would like to achieve.
This panel uses only selectableLabel and Frame::group.
image

Describe the solution you'd like

  1. Tabs required their own styling for active/inactive and hover.
    Right now inactive tabs take on the color of the Tab bar. However it should be possible to seperate an active tab from an inactive tab from the tab bar from the panel background.

  2. Tabs need a spacing style to seperate tabs from each other.
    Tabs are very much pressed together right now. It would be nice to visually relax this by seprating the tabs a little.

  3. Tab bodies need their own background color to seperate them from the tabs.
    Technically not necessary but still usefull. Otherwise you have to create a new frame on top of the panel body with the actual background color you want.

  4. Border around the dock area.
    There exists a border style however it doesnt really work. It is somehow connected to the top margin.
    In either case a border around the table would include the table bar.
    You can already kinda do this with another frame around the DockArea. However if you have any rounding on the frame, the tabs will poke their corners through the border.

  5. A Border around a tab body.
    You can also do this by setting the inner_margin to zero and open a new frame inside the tab. However it would way nice if you could do this with a simple style instead.

@LennysLounge LennysLounge added the enhancement New feature or request label Jun 3, 2023
@Adanos020
Copy link
Owner

These are great ideas, we should look into implementing them.

@LennysLounge
Copy link
Contributor Author

I can open a PR if you like?

@Adanos020
Copy link
Owner

Yes please!

Before you do, check if any of the changes are breaking. If they are, open it for branch release-0.7, otherwise main.

@Adanos020
Copy link
Owner

Closed by #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants