Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flwr.__version__ #883

Closed
danieljanes opened this issue Oct 17, 2021 · 3 comments
Closed

Add flwr.__version__ #883

danieljanes opened this issue Oct 17, 2021 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@danieljanes
Copy link
Member

danieljanes commented Oct 17, 2021 •
edited

Having flwr.__version__ will enable programmatic version checking, similar to how other libraries do it (e.g., numpy, tensorflow, torch, torchvision)
@danieljanes danieljanes changed the title Add __version__ file Add flwr.__version__ Oct 17, 2021
@danieljanes danieljanes added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 25, 2021
@sisco0
Copy link
Contributor

sisco0 commented Dec 20, 2021

Maybe the way to go for not duplicating the Poetry version name is just the one specified in python-poetry/poetry#144 (comment).

@sisco0 sisco0 mentioned this issue Dec 20, 2021
Merged
@sisco0
Copy link
Contributor

sisco0 commented Dec 28, 2021

We need to open a second step for this issue where we create a test for the version. Checking if __version__ is a string is an option as pointed out in #952 (review).

@tanertopal
Copy link
Member

@sisco0 I added a simple test for it #967. We can successfully close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tanertopal @danieljanes @sisco0