Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing comma in "Event Happened // property," shouldn't lead to validation errors #7

Closed
robertreppel opened this issue Apr 14, 2018 · 0 comments
Closed

Trailing comma in "Event Happened // property," shouldn't lead to validation errors #7

robertreppel opened this issue Apr 14, 2018 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@robertreppel
Copy link
Contributor

robertreppel commented Apr 14, 2018 •
edited

When running les validate with

# test
command->
Event Happened // property,

Results in:

EML Errors:
NoPropertyName: test-Event: EventHappened: Event property names cannot be blank.

InvalidEventPropertyName: test-Event: Invalid event property name '': Names must start with a character and contain no spaces.

There is no real reason why this shouldn't result in valid EML. The trailing comma can be stripped when converting EMD to EML.
@robertreppel robertreppel added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 14, 2018
markgukov added a commit to markgukov/les that referenced this issue Apr 17, 2018
@markgukov
Adaptech#7 - trailing comma in a properties list shouldn't lead to va…
a48e132 
…lidation errors
robertreppel pushed a commit that referenced this issue Apr 18, 2018
@markgukov
#7 - trailing comma in a properties list shouldn't lead to validation…
4c88bb2 
… errors
adymitruk pushed a commit that referenced this issue May 4, 2018
@markgukov
#7 - trailing comma in a properties list shouldn't lead to validation…
c7a71ec 
… errors
adymitruk pushed a commit that referenced this issue May 4, 2018
@markgukov
#7 - trailing comma in a properties list shouldn't lead to validation…
dd5bb7e 
… errors
robertreppel pushed a commit that referenced this issue Aug 16, 2018
@markgukov
#7 - trailing comma in a properties list shouldn't lead to validation…
9458e9a 
… errors
robertreppel pushed a commit that referenced this issue Aug 16, 2018
@markgukov
#7 - trailing comma in a properties list shouldn't lead to validation…
d689f9a 
… errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robertreppel