Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DebertaV2/V3 #269

Closed
ianupright opened this issue Jan 12, 2022 · 5 comments · Fixed by #340
Closed

Add support for DebertaV2/V3 #269

ianupright opened this issue Jan 12, 2022 · 5 comments · Fixed by #340
Labels
enhancement New feature or request

Comments

@ianupright
Copy link

Please add support for DebertaV2/V3

@ianupright ianupright added the enhancement New feature or request label Jan 12, 2022
@ianupright
Copy link
Author

I might take a stab at this if nobody else does

@hSterz
Copy link
Member

hSterz commented Jan 13, 2022

Hey,
at the moment we, unfortunately, do not plan to support DebertaV2/V3 in the near future. Feel free to take a stab at that and reach out to us if you have any problems. In adding_adapters_to_a_model.md you can find all necessary and optional steps to add adapters to a model. We always appreciate someone taking the initiative to add adapters to a model.

@calpt
Copy link
Member

calpt commented Jan 14, 2022

@ianupright, adding to @hSterz's answer, I'd like to note that we're currently in the process of doing a larger refactoring of the model integrations of adapters (cf PR #263). As this simplifies quite a few of the implementation steps needed to add support to a new model architecture, I think it would make sense to wait until #263 is merged before starting a new model integration. Anyways, we'd be happy to have your help then. I'll let you know when the refactoring is completed.

@calpt
Copy link
Member

calpt commented Apr 19, 2022

Hey @ianupright, just wanted to know if you were still interested in working on this. Otherwise, we'd be happy to take over the Deberta implementation :)

@ianupright
Copy link
Author

Hey @calpt please go ahead.. I haven't had time.

@calpt calpt linked a pull request May 16, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants