Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PGAME Replay Buffer delete newest solutions #71

Closed
manon-but-yes opened this issue Jul 30, 2022 · 2 comments
Closed

PGAME Replay Buffer delete newest solutions #71

manon-but-yes opened this issue Jul 30, 2022 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@manon-but-yes
Copy link
Collaborator

Hi :)

The current PGAME Replay Buffer is using jax.lax.dynamic_update_slice to add new transition to the replay buffer.
However, this is not acting like a circular buffer, meaning that if a batch contain more transitions than the size remaining in the buffer, it would delete the more recent transitions instead of the oldest ones.

@manon-but-yes manon-but-yes added the bug Something isn't working label Jul 30, 2022
@felixchalumeau
Copy link
Collaborator

Hi!

Thanks for raising this issue!

Indeed, the current replay buffer, inspired by Brax's implementation, does not handle overflow correctly.

We recently had a look at Brax's replay buffer implementation and they recently spotted this issue as well and fixed it. I would suggest to use their new way to handle it. What do you think about it?

@felixchalumeau
Copy link
Collaborator

Fixed by #75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants