Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position of the trickle button covers some content #32

Closed
LukaszGrela opened this issue Jan 28, 2015 · 5 comments
Closed

Position of the trickle button covers some content #32

LukaszGrela opened this issue Jan 28, 2015 · 5 comments

Comments

@LukaszGrela
Copy link
Contributor

At the moment the trickle button is placed at bottom of the last visible container, this can cause the issue that the trickle button will cover the content of that container (e.g. block). Can the trickle be positioned at the top of the next (invisible) container? This way the padding between containers will give the breathing space between content and trickle button.

@LukaszGrela
Copy link
Contributor Author

It is placed at the bottom of the browser:) but could it add padding to the body when visible? I'll try with it later, maybe it will work.

@oliverfoster
Copy link
Member

The body or the #wrapper element should work. The height of the button + 20pxish.

@LukaszGrela
Copy link
Contributor Author

Yes, I thought of body as it will always be there and usually without any style (padding) added.

@zenduo
Copy link
Contributor

zenduo commented Mar 22, 2015

Can this one be closed now? Works well in develop branch.

@oliverfoster
Copy link
Member

The pr for this went in last week. Good to close.

@zenduo zenduo closed this as completed Mar 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants