Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate the localization logic to save the coding effort #55

Closed
SummerSun opened this issue Jan 9, 2018 · 1 comment
Closed

separate the localization logic to save the coding effort #55

SummerSun opened this issue Jan 9, 2018 · 1 comment
Labels
eng

Comments

@SummerSun
Copy link
Contributor

Have to write multiple copies of code snippet when the string need to be localized such as Utility.localize('tomcatExt.selectdirectory', 'Select Tomcat Directory').

Wrap the vscode localize function to a localize.ts file. And leverage it to define strings or MessageItems in a separate DialogMessage.ts file.
@SummerSun SummerSun added the eng label Jan 9, 2018
@SummerSun SummerSun changed the title [EE] separate the localization logic to save the coding effort separate the localization logic to save the coding effort Jan 9, 2018
@SummerSun
Copy link
Contributor Author

Completed in PR 56

@SummerSun SummerSun mentioned this issue Jan 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
eng
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SummerSun