Sourcery refactored master branch

[sourcery-ai]

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[sourcery-ai]

Lines 58-195 refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

This removes the following comments ( why? ):

# iOS 'emoji' characters (some smileys, some symbols) [\ue001-\uebbb]
# Standard version  :) :( :] :D :P
# myleott: o.O and O.o are two of the biggest sources of differences
# reversed version (: D:  use positive lookbehind to remove "(word):"
# TODO should try a big precompiled lexicon from Wikipedia, Dan Ramage told me (BTO) he does this
#          between this and the Java version. One little hack won't hurt...
#inspired by http://en.wikipedia.org/wiki/User:Scapler/emoticons#East_Asian_style
# because eyes on the right side is more ambiguous with the standard usage of : ;

[sourcery-ai]

Function MapPool refactored with the following changes:

• Inline variable that is immediately yielded (inline-immediately-yielded-variable)

[sourcery-ai]

Function CorpusIndexer.__init__ refactored with the following changes:

• Replace a for append loop with list extend (for-append-to-extend)

[sourcery-ai]

Function CorpusIndexer.prune_min_domain refactored with the following changes:

• Use named expression to simplify assignment and conditional (use-named-expression)

This removes the following comments ( why? ):

# Remove the languages from the indexer

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 1.14%.

Quality metrics	Before	After	Change
Complexity	15.48 🙂	18.77 😞	3.29 👎
Method Length	59.99 ⭐	52.08 ⭐	-7.91 👍
Working memory	10.82 😞	10.28 😞	-0.54 👍
Quality	56.72% 🙂	57.86% 🙂	1.14% 👍

Other metrics	Before	After	Change
Lines	1695	914	-781

Changed files	Quality Before	Quality After	Quality Change
py3langid/langid.py	49.48% 😞	49.48% 😞	0.00%
py3langid/tools/printfeats.py	94.84% ⭐	96.01% ⭐	1.17% 👍
py3langid/train/common.py	80.33% ⭐	81.22% ⭐	0.89% 👍
py3langid/train/index.py	63.10% 🙂	63.28% 🙂	0.18% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
py3langid/langid.py	main	65 ⛔	623 ⛔	17 ⛔	7.88% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
py3langid/langid.py	application	21 😞	223 ⛔	15 😞	30.34% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
py3langid/train/index.py	CorpusIndexer.__init__	10 🙂	146 😞	12 😞	50.01% 🙂	Try splitting into smaller methods. Extract out complex expressions
py3langid/train/index.py	CorpusIndexer.prune_min_domain	9 🙂	104 🙂	11 😞	57.78% 🙂	Extract out complex expressions
py3langid/langid.py	LanguageIdentifier.set_languages	7 ⭐	88 🙂	12 😞	60.16% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!