Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German lemmatization: Definite articles #28

Closed
GrazingScientist opened this issue Nov 21, 2022 · 2 comments
Closed

German lemmatization: Definite articles #28

GrazingScientist opened this issue Nov 21, 2022 · 2 comments
Labels
question Further information is requested

Comments

@GrazingScientist
Copy link

GrazingScientist commented Nov 21, 2022

Hi @adbar,

thanks for providing this really cool (and capable) library.

Currently, all German definite articles ("der", "die", "das") are lemmatized to "der", which is wrong.

import simplemma
simplemma.lemmatize("Das", lang=('de',))
# Output: 'der'
simplemma.lemmatize("Die", lang=('de',))
# Output: 'der'
simplemma.lemmatize("Der", lang=('de',))
# Output: 'der'

Normally, I would not be too picky about wrong lemmatization (this happens all the time). But since these are among the most common German words, this should be correct. Their respective lemma should be the same word each: "Das" -> "Das", "Die" -> "Die", "Der" -> "Der". The lemma should be lowercase, if the original token is lowerecased, too.

@adbar adbar added the question Further information is requested label Nov 21, 2022
@adbar
Copy link
Owner

adbar commented Nov 21, 2022

Hi @GrazingScientist, there are reasons for this behavior: In most treebanks the definite articles are reduced to a single version, mostly "der" or "d". That why I opted for this form, it's a choice, even if it's questionable.

As a side note, writing lang=('de') (i.e. string instead of tuple) should be fine.

@GrazingScientist
Copy link
Author

☹️ Okay! Thanks for clarifying this. ❤️

@GrazingScientist GrazingScientist closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants