Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Please elaborate on the greedy parameter #29

Closed
GrazingScientist opened this issue Nov 22, 2022 · 2 comments
Closed

Documentation: Please elaborate on the greedy parameter #29

GrazingScientist opened this issue Nov 22, 2022 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@GrazingScientist
Copy link

Hi @adbar ,

could you please in you documentation go into detail on what the greedy parameter actually does. In the documentation, it is mentioned as if it would be self-explanatory. However, I really cannot estimate its potential/dangers.

Thanks! 😃

@adbar adbar added the documentation Improvements or additions to documentation label Nov 22, 2022
@adbar
Copy link
Owner

adbar commented Jan 19, 2023

Quick update: I'm currently working on relevant code parts and I'm also redefining what the concept means. So I'm waiting for the code to stabilize before updating the documentation.

Basically the greedy option currently (v0.9.0) means:

  1. a certain capacity to address affixes in an unsupervised way
  2. a stronger reduction through a further iteration of the search algorithm
    e.g. "angekündigten" → "angekündigt" (standard) → "ankündigen" (greedy).

In the future it's probably going to be reduced to (2), the benefits of (1) will be integrated without needing intervention by the users. In some cases (2) is closer to stemming than to lemmatization, this should be mentioned in the docs.

@GrazingScientist
Copy link
Author

Thanks for the update. Seems I need to consider being "greedy". 😁

@adbar adbar closed this as completed Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants